Repository navigation
generation: Confirm repeated share copies - #197
BenWestgate wants to merge 3 commits into
Conversation
Permit repeated output indices as physical copies while requiring distinct indices for the recovery threshold. Schedule original cards before copies and reuse only independently confirmed cards.\n\nrefs #103
Document first-occurrence ordering and physical-copy confirmation for repeated output indices. Format the related generation regression test.\n\nrefs #103
Cover failed physical-copy confirmation and repeated-card creation from an existing master seed. These tests protect the distinction between share copies and distinct recovery indices. refs #103
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BenWestgate
added
documentation
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted security review: ACK e0b538c against bbdb1e4. Reviewed all three changed files and interpolation/CLI callers. Copies preserve the distinct random basis and require separate confirmation. No security findings. Generation: 45 tests pass normally and optimized; CLI: 243 pass; Ruff and mypy pass. This reviews my earlier implementation; independent maintainer review remains needed.
Split from #103. Repeated output indices request independently confirmed physical copies of the same share, not additional threshold shares. Originals are handled before copies (
aacd→acda); at leastthresholddistinct indices remain required.Changes only generation, its tests, and the API contract. Replaces #196, whose outdated base mixed in unrelated Core Lightning removals.
Validation: 286 normal and 288 optimized tests, Ruff, and generation mypy passed on the isolated branch;
git diff --checkclean. Human review still required.