Repository navigation
[SVLS-8713] test(logs): pin that a reloaded API key is used on the next flush - #1451
Draft
litianningdatadog wants to merge 1 commit into
Draft
litianningdatadog wants to merge 1 commit into
litianningdatadog wants to merge 1 commit into
Conversation
This was referenced Oct 21, 2026
Draft
Draft
Draft
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
ℹ️ Info🔄 Datadog auto-retried 2 jobs - 1 passed on retry Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: ba431aa | Docs | View more details | Give us feedback! |
Why: after the logs agent migration, a reloaded API key (api_key_secret_reload_interval) must still be sent on the next flush. That works today only because each endpoint's flusher is cloned on every flush, which rebuilds its saved request headers; no test pinned it. What: a new contract test reloads the key between two flushes and checks that the second request carries the new key. A test helper builds the pipeline with a key factory that reloads after 1 ms. No production code changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
litianningdatadog
force-pushed
the
tianning.li/logs-bc-fix-3-reload-key
branch
from
October 21, 2026 19:53
36d67b6 to
ba431aa
Compare
litianningdatadog
force-pushed
the
tianning.li/logs-bc-fix-2-oversize-drop
branch
from
October 21, 2026 19:53
80158f6 to
3f01719
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Part of SVLS-8713: bottlecap is replacing its own logs aggregator and flusher with the shared
datadog-logs-agentcrate from serverless-components. Lambda users must not notice the swap, so the plan is: pin today's behavior with tests (this stack), fix two real bugs first so the swap stays a pure refactor (this stack), then swap the aggregator and the flusher (bc-1 and bc-2, which will be opened after the serverless-components PRs merge).Tests only, no production code. A new contract test reloads the API key between two flushes (
api_key_secret_reload_interval) and checks that the second request carries the new key.This works today only because each endpoint's flusher is cloned on every flush, which rebuilds its cached headers; nothing pinned it. The swap to the shared flusher must keep it.
Testing
761 tests pass (contract 36/36). clippy and fmt clean.
Stack
Each PR is nested under the PR it builds on (and targets). Review and merge from the top down.
serverless-components (
datadog-logs-agentoptions; merge first)maindefault/fipsfeaturesretry()+FlushPolicydatadog-lambda-extension (bottlecap)
main🤖 Generated with Claude Code