Repository navigation
[SVLS-8713] build(logs-agent): let users choose the FIPS TLS backend - #190
Draft
litianningdatadog wants to merge 1 commit into
Draft
litianningdatadog wants to merge 1 commit into
litianningdatadog wants to merge 1 commit into
Conversation
This was referenced Oct 21, 2026
Why: bottlecap's FIPS build refuses to link the non-FIPS "ring" crypto library. This crate always turned on datadog-fips' default features, which pull ring in, so bottlecap could not use it in FIPS builds. What: the crate now has a "default" feature that keeps today's TLS setup and a "fips" feature that selects the FIPS backend instead. Anyone using the crate with default features gets exactly the same build as before. Builds that turn default features off must now enable either "default" or "fips", otherwise the crate does not compile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
litianningdatadog
force-pushed
the
tianning.li/logs-sc-1-fips-features
branch
from
October 21, 2026 19:50
db2d5af to
c3f11c2
Compare
litianningdatadog
force-pushed
the
tianning.li/logs-sc-0-characterization
branch
from
October 21, 2026 19:50
8bf6920 to
2c0a3f9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds two features to
datadog-logs-agent:default(today's TLS setup viadatadog-fips/default) andfips(selects the FIPS backend). Cargo.toml only.Motivation
Part of SVLS-8713: bottlecap (the Datadog Lambda Extension) is replacing its own logs aggregator and flusher with this crate. Two rules for the whole stack:
bottlecap's FIPS build refuses to link the non-FIPS
ringcrate. This crate always enableddatadog-fips' default features, which pull inring, so bottlecap couldn't use it in FIPS builds.Additional Notes
With default features nothing changes. Builds that turn default features off must now enable
defaultorfips, otherwise the crate doesn't compile (Cargo has no negative features, so this is the only way to let a consumer dropring).Describe how to test/QA your changes
All 80 tests pass.
cargo tree -e features -i ring --no-default-features --features fipsshows noring; clippy is clean with--no-default-features --features fips.Stack
Each PR is nested under the PR it builds on (and targets). Review and merge from the top down.
serverless-components (
datadog-logs-agentoptions; merge first)maindefault/fipsfeatures ← this PRretry()+FlushPolicydatadog-lambda-extension (bottlecap)
main🤖 Generated with Claude Code