Repository navigation
StoreTest: wait for the table holder to die before teardown (MOB-502) - #225
Merged
Merged
Conversation
Owner
Author
|
Review: reviewer subagent (Codex usage-limited): SHIP. Its P3 finding is fixed in fa37d3f: in the heir-kill test, the owner re-points its tables at the restarted heir after the assertions, so teardown could hit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOB-502.
Mob.Diag.StoreTest"a loss onto tables an older mob still holds…" spawns a process that owns the store's tables, and its on_exit only sent the kill. ExUnit runs on_exit callbacks in reverse order, so the setup'stear_down/1ran right after. The holder's death (which deletes its tables) could land between tear_down's:ets.whereisand:ets.delete, and the delete raised ArgumentError.Fix: the on_exit uses the module's
kill/1, which waits for the exit, as the other holder in this file already did.Reproduced on master: 1 failure in 63 runs of the file, the exact error from the issue. After: 903 runs (3×300 with --repeat-until-failure) with 0 failures. A separate failure appeared once at :191 (an
eventuallywith a 1000 ms deadline) while the host was at load average ~400; it is unrelated and not changed here.