Skip to content

StoreTest: wait for the table holder to die before teardown (MOB-502) #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GenericJam merged 2 commits into from
Oct 24, 2026
Merged

StoreTest: wait for the table holder to die before teardown (MOB-502) #225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38a07cc
StoreTest: wait for the table holder to die before teardown (MOB-502)
GenericJam Oct 24, 2026
fa37d3f
StoreTest: wait for the restarted heir to hold the tables before tear…
GenericJam Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions test/mob/diag/store_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,18 @@ defmodule Mob.Diag.StoreTest do
kill(first)
replacement = await_replacement(TestStore, first)

kill(Process.whereis(Mob.Diag.Heir))
heir = Process.whereis(Mob.Diag.Heir)
kill(heir)

# The owner re-points each table at the restarted heir on its own; wait
# for that, or teardown can delete a table mid-setopts and crash the
# owner (MOB-502).
ProcessHelpers.eventually(fn ->
new_heir = Process.whereis(Mob.Diag.Heir)

is_pid(new_heir) and new_heir != heir and
Enum.all?(TestStore.tables(), fn {t, _} -> :ets.info(t, :heir) == new_heir end)
end)

assert owner(TestStore) == replacement
assert held_by(TestStore) == [:owner, :owner]
Expand Down Expand Up @@ -734,7 +745,10 @@ defmodule Mob.Diag.StoreTest do

assert_receive :held

on_exit(fn -> Process.exit(holder, :kill) end)
# Wait for the death, not just send the kill: the holder's tables go
# with it, and a death landing during tear_down's whereis-then-delete
# made that delete raise (MOB-502).
on_exit(fn -> kill(holder) end)

assert Store.guard(TestStore, :fallback, fn -> raise "boom" end) == :fallback
assert Store.health(TestStore).lost == 1
Expand Down
Loading