Skip to content

build: remove unused dependencies spotbugs and jakarta #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c-dilks merged 1 commit into from
Oct 8, 2026
Merged

build: remove unused dependencies spotbugs and jakarta #1487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,18 +58,6 @@
<dependencyManagement>
<dependencies>

<dependency>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs</artifactId>
<version>4.10.4</version>
</dependency>

<dependency>
<groupId>jakarta.annotation</groupId>
<artifactId>jakarta.annotation-api</artifactId>
<version>3.0.0</version>
</dependency>

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down
4 changes: 0 additions & 4 deletions reconstruction/ltcc/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@
</parent>

<dependencies>
<dependency>
<groupId>jakarta.annotation</groupId>
<artifactId>jakarta.annotation-api</artifactId>
</dependency>
<dependency>
<groupId>org.jlab</groupId>
<artifactId>groot</artifactId>
Expand Down
7 changes: 3 additions & 4 deletions reconstruction/ltcc/src/main/java/org/jlab/service/ltcc/LTCCHit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

import java.util.LinkedList;
import java.util.List;
import jakarta.annotation.Nullable;
import org.jlab.detector.banks.RawDataBank;
import org.jlab.geom.prim.Vector3D;

Expand Down Expand Up @@ -86,9 +85,9 @@ public static List <LTCCHit> loadHits(DataEvent event) {

LTCCHit(RawDataBank bank,
int index,
@Nullable IndexedTable spe,
@Nullable IndexedTable timing_offset,
@Nullable IndexedTable status_table) {
IndexedTable spe,
IndexedTable timing_offset,
IndexedTable status_table) {
this.sector = bank.getByte("sector", index);
this.segment = bank.getShort("component", index);
this.side = bank.trueOrder(index) + 1;
Expand Down
Loading