Repository navigation
Fix reported multidict and Go dependency vulnerabilities - #92
Merged
Merged
Conversation
Signed-off-by: Johnny Greco <jogreco@nvidia.com>
Signed-off-by: Johnny Greco <jogreco@nvidia.com>
Collaborator
Author
|
@codex review Please review this PR's fixes for the NSpect report: multidict 6.7.1, golang.org/x/net v0.58.0, and golang.org/x/crypto v0.57.0. Check the patched versions, dependency compatibility, lockfile integrity, and the version-specific multidict license clarification. Keep findings tied to the changes in this PR; the request explicitly excludes scope creep. The PR description records the Darwin-only validation limit and unchanged Go toolchain advisories outside the supplied report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NSpect report lists three vulnerable dependencies. Upgrade each to the report's short-term fixed version:
Add a multidict security floor and regenerate
uv.lockwith uv 0.11.0 to preserve the existing format. No other Python versions change. The upgraded Go modules require x/sys v0.49.0, x/term v0.47.0, and x/text v0.43.0;go mod tidyrefreshes their checksums and required x/sync/x/tools checksums. Add a version-specific Apache-2.0 clarification backed by multidict's upstream license, because PyPI reports the non-SPDX stringApache License 2.0. Five files change, with 39 additions and 28 deletions.The multidict advisory identifies 6.9.1 as patched. OSV reports no advisories for multidict 6.9.1 or x/net v0.60.0. x/crypto v0.58.0 retains GO-2026-5932, covering unmaintained OpenPGP packages with no fixed release. The exporter README already records this exception. Rechecked build/test imports: no OpenPGP packages; govulncheck finds that advisory only at module level and no findings for x/net.
Validation:
go mod verify,go mod tidy -diff,go vet ./...,go test -race ./..., andgo build ./cmd/...pass with Go 1.26.8.uv lock --check,ruff check ., compileall, andgit diff --checkpass.1f1004d7df7c888d1e71a5c2d9cec8243a780335.Validation limits and scope: full Reachy sync/test/type validation cannot complete on this Linux host because the committed lockfile targets Darwin and native runtime packages are unavailable. govulncheck also reports 11 existing standard-library vulnerabilities in unchanged Go 1.26.8; those are outside the supplied package report. Application code, platform support, and the Go toolchain are unchanged.
Independent subagent review: clean, no actionable findings, for base
cb153d63c54ea095b69b0a5d8e21f65a8c1227f3to head1f1004d7df7c888d1e71a5c2d9cec8243a780335. The reviewer independently passed Go module verification/tidy/vet/race/build checks, uv lock validation, 15 Reachy REST/package tests, PyPI artifact integrity checks, and 10,000 C-extension union/subtraction reference-count cycles. No OpenPGP paths appear among 1,613 build/test dependencies. Additional Python collection remains limited by the temporary Linux environment's missing fastrtc/native packages, consistent with the validation limits above. No scope expansion or file changes were requested by the review.