Repository navigation
Add an Identification QC page (score distribution, precursor error, PSMs per file) - #42
Open
t0mdavid-m wants to merge 1 commit into
Open
t0mdavid-m wants to merge 1 commit into
t0mdavid-m wants to merge 1 commit into
Conversation
…SMs per file First step towards feature parity with the ProSE web app's QC tab. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D5Wo2FHPpi5a8X6GppNxEk
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tom · project thread
Before: the only way to judge a search's quality was to scroll each run's PSM table one file at a time. There was no view of target/decoy separation, mass calibration, or run-to-run consistency.
After: a new page, Workflow Results › Identification QC, puts three plots over all runs on one page:
This is the first item on the list for parity with the QC tab of Timo Sachsenberg's ProSE web app (timosachsenberg/prose-web).
How:
src/common/qc_plots.pyreads the existingpercolator_resultsandpsm_filteridXMLs into one flat table per run (top hit only). Pages cache it withst.cache_data, keyed on file mtimes. The plots are Plotly figures shown throughshow_fig(). OpenMS-Insight has no histogram or bar component, so Plotly is used here. The workflow itself is unchanged.Validation:
pytest test_gui.py tests/: 123 passed, including 4 new tests intests/test_qc_plots.pythat run on synthetic idXMLs.pylint --errors-only: no errors in the new files.Generated by Claude Code