Repository navigation
Add OAuth client credentials support - #230
Conversation
9bcbe5a to
5336b6c
Compare
soe-relewise
left a comment
There was a problem hiding this comment.
Please address the two P2 recovery issues below before merging: a stalled shared token acquisition has no SDK-controlled lifetime, and empty authentication-list elements prevent invalid_token recovery. Both were reproduced against this commit and independently validated by three reviewers.
The separate P3 comment about sanitizing malformed token responses is defensive hardening, not a reason for requesting changes on its own.
Validation: all 113 client unit tests, npm run build, and npm run build:types passed locally using the installed tooling. Focused checks reproduced the additional cases below. Live OAuth integration tests were not run. PHP PR #86 provides useful existing examples of bounded acquisition and empty-list handling.

https://trello.com/c/RyptoX8f/22757-js-sdk-add-support-for-oauth
Scope
@relewise/clientbase client.invalid_tokenchallenge.Integrations support is split into the stacked PR #232.
Risk
Validation
packages/client: npm run buildpackages/client: npm run build:typespackages/client: npm testtest-sdkThe live OAuth test previously acquired a token successfully but received 403 until product-view permission was granted; it was not rerun with the exposed credential. The credential should be rotated.
API generation
npm run gen-apinot run because no Swagger-generated contracts changed.