Repository navigation
Add OAuth support to integrations - #232
Conversation
67239b2 to
4e8c5b6
Compare
soe-relewise
left a comment
There was a problem hiding this comment.
Please update the integrations dependency metadata and lockfile once the client release containing #230 is published, before merging this PR.
The documented stacking/release sequence explains the current CI failure. The remaining issue is that publishing the client and retargeting this PR will not update the existing lockfile or stop consumers from selecting an incompatible client version. The new constructor forwarding itself looks consistent with #230.
Validation: independent TypeScript checks against the currently locked @relewise/client 2.24.0 reproduced four missing-export errors, matching the current test-integrations CI failure. This finding was independently validated by three reviewers.
soe-relewise
left a comment
There was a problem hiding this comment.
Approved for the current target, codex/add-oauth-support (#230). This supersedes my earlier request for changes.
My mistake was treating the dependency/lockfile update needed for release as a blocker to merging this stacked PR into its parent feature branch. The PR already documents its dependency on #230 and the subsequent client publication. I have corrected and resolved the inline finding.
I rechecked the two-file diff against #230's client constructor: the API-key overloads remain available, the OAuth overloads require the OAuth options, and the credentials object is forwarded unchanged at runtime. The current CI failure is caused by installing the older published client from the lockfile, not by the forwarding implementation.
The client version range and lockfile still need updating, with passing checks, before publishing integrations. This approval does not claim the currently failing CI is green. No new tests were run for this correction.
4e8c5b6 to
c31eb96
Compare
https://trello.com/c/RyptoX8f/22757-js-sdk-add-support-for-oauth
Stacked on #230.
Scope
IntegratorandDataAccessor.Dependency
@relewise/clientversion to be published.mainso the normal integrations CI runs against the published client.Risk
Validation
packages/integrations: npm run buildpackages/integrations: npm testBoth pass locally against the client implementation from #230.