Skip to content

Add OAuth support to integrations - #232

Merged
mzanoni merged 2 commits into
mainfrom
codex/add-oauth-integrations
Oct 21, 2026
Merged

mzanoni merged 2 commits into
mainfrom
codex/add-oauth-integrations

Conversation

@mzanoni

@mzanoni mzanoni commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

https://trello.com/c/RyptoX8f/22757-js-sdk-add-support-for-oauth

Stacked on #230.

Scope

  • Add OAuth client-credentials constructor overloads to Integrator and DataAccessor.
  • Preserve the existing API-key constructor signatures.

Dependency

  • Requires Add OAuth client credentials support #230 to be merged and the corresponding @relewise/client version to be published.
  • After that release, retarget this PR to main so the normal integrations CI runs against the published client.

Risk

  • Limited to integrations client construction.

Validation

  • packages/integrations: npm run build
  • packages/integrations: npm test

Both pass locally against the client implementation from #230.

@mzanoni
mzanoni added this pull request to stack #233 October 21, 2026 10:35
@mzanoni
mzanoni requested a review from soe-relewise October 21, 2026 10:36
@mzanoni
mzanoni force-pushed the codex/add-oauth-integrations branch from 67239b2 to 4e8c5b6 Compare October 21, 2026 10:36

@soe-relewise soe-relewise left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the integrations dependency metadata and lockfile once the client release containing #230 is published, before merging this PR.

The documented stacking/release sequence explains the current CI failure. The remaining issue is that publishing the client and retargeting this PR will not update the existing lockfile or stop consumers from selecting an incompatible client version. The new constructor forwarding itself looks consistent with #230.

Validation: independent TypeScript checks against the currently locked @relewise/client 2.24.0 reproduced four missing-export errors, matching the current test-integrations CI failure. This finding was independently validated by three reviewers.

Comment thread packages/integrations/src/integrator.ts

@soe-relewise soe-relewise left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for the current target, codex/add-oauth-support (#230). This supersedes my earlier request for changes.

My mistake was treating the dependency/lockfile update needed for release as a blocker to merging this stacked PR into its parent feature branch. The PR already documents its dependency on #230 and the subsequent client publication. I have corrected and resolved the inline finding.

I rechecked the two-file diff against #230's client constructor: the API-key overloads remain available, the OAuth overloads require the OAuth options, and the credentials object is forwarded unchanged at runtime. The current CI failure is caused by installing the older published client from the lockfile, not by the forwarding implementation.

The client version range and lockfile still need updating, with passing checks, before publishing integrations. This approval does not claim the currently failing CI is green. No new tests were run for this correction.

Base automatically changed from codex/add-oauth-support to main October 21, 2026 13:19
@mzanoni
mzanoni force-pushed the codex/add-oauth-integrations branch from 4e8c5b6 to c31eb96 Compare October 21, 2026 13:19
@mzanoni
mzanoni merged commit b9c2e15 into main Oct 21, 2026
2 checks passed
@mzanoni
mzanoni deleted the codex/add-oauth-integrations branch October 21, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants