Repository navigation
build(bazel): update to 9.3.1 and reuse eval process ownership - #4391
Conversation
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
ScriptedAlchemy
left a comment
ScriptedAlchemy
left a comment
There was a problem hiding this comment.
Pushed dc2f502 to fix two concrete test-harness defects exposed by native CI run 39546567859.
- The ten host-lifecycle readiness failures probed 112-byte profile socket paths. Production already relocates these through
default_socket_path; the test now uses that same canonical endpoint. It captures daemon stderr and reports early child exit, retains the existing 30-second deadline, and removes only a fallback directory created by this fixture after reaping its daemon. Added a real long-profile daemon/doctor regression. - The memory eval helper kept a raw child while creating pipe-reader threads. A thread-admission panic or timeout could leave the child alive. It now arms the existing
TestChildProcessowner immediately and uses its canonical output wait/cleanup path, with the existing timeouts unchanged.
Validation: the local Unix-socket reproduction rejects the 112-byte endpoint and connects successfully to the short endpoint; pinned rustfmt, diff checks, and commitlint pass. The native Bazel suites are left to CI because this environment cannot run them reliably. The memory ownership fix does not establish the initial cause of OS EAGAIN in this run; fresh CI still needs to verify that and the remaining runtime tests.
# Conflicts: # crates/tracedecay-cli/tests/host_journeys_suite/host_lifecycle_cli_acceptance/sweep_outcomes.rs
ScriptedAlchemy
changed the title
Advance the Bazel pin from 9.3.0 to 9.3.1. Memory evaluation uses the shared TestChildProcess owner for output capture and timeout cleanup, replacing duplicate pipe-draining threads and keeping ownership active through capture failures. Retire the first scenario daemon before opening an independent violation store.
The long-profile Doctor journey runs in an isolated subprocess when a socket override is inherited, removing that override so it exercises canonical fallback-socket placement and cleanup.
Validation on
8c8b40480920e05f22c266462ef7fbfa1be2bd9b: full hosted CI passed, including Linux fleet and aggregate, Clippy, shipped CLI packaging and transport checks, repository gates, dashboard, feature gates, and benchmark harness checks. Native OS and stock-host jobs were skipped by their normal scope conditions. The preceding integration also passed all 57 LSP integration tests locally through remote Bazel workers.