Repository navigation
feat: state validation and execution engine for generalized transactions - #164
Open
SIDDHANTCOOKIE wants to merge 3 commits into
Open
SIDDHANTCOOKIE wants to merge 3 commits into
SIDDHANTCOOKIE wants to merge 3 commits into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Legacy transactions now run through the generalized engine. Fixes the generalized deploy address (nonce-1, same-tx collisions), charges gas for minters paying in their own token, caps component count, and stops validation from creating empty accounts.
SIDDHANTCOOKIE
force-pushed
the
feature/generalized-tx-state
branch
from
October 18, 2026 19:27
53c53d8 to
f2d694d
Compare
Withdrawals must equal deposits plus call amounts per asset, so burns must be explicit deposits to the burn address with ALLOW_BURN.
SIDDHANTCOOKIE
added this pull request to stack #158
October 18, 2026 20:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 2 of the generalized transaction roadmap (stacked on PR #163). It implements the state validation and execution engine for generalized transactions in \minichain/state.py.
Key Features:
Test Plan