Repository navigation
snitch_cluster: rename SRAM macros to platform-neutral fakeram_* prefix - #248
Merged
Merged
Conversation
The shared tc_sram.sv mapping hardcoded asap7-style fakeram7_* macro names on every platform (nangate45 shipped fakeram7_* LEFs, and the gt2n port in PR #240 inherited the misleading '7'). Rename suite-wide to the platform-neutral fakeram_* prefix used by the other gt2n designs. - tc_sram.sv + fakeram cfgs: fakeram7_* -> fakeram_* - asap7 normalized to the standard macro layout: cfg at dev/generated/fakeram_asap7.cfg, committed LEF/LIB at designs/asap7/snitch_cluster/sram/{lef,lib}/ (replaces the tracked dev/generated/sram/ tree and the src-level sram_lefs/sram_libs filegroups); tools/regenerate_sram.sh now works for both platforms - asap7 cfg snap keys fixed snake_case -> camelCase (the known silently-ignored-snap bug): macros now land exactly on the 0.190/1.400 um site grid, size deltas +0.06-0.5% per side - nangate45 LEF/LIB regenerated: byte-identical except the names Both platforms' cached results invalidate; rebuild required (nangate45 ~14 h). gt2n (PR #240) regenerates with the new names.
Same cleanup as the snitch_cluster rename: the fakeram7_* prefix was asap7 naming carried onto nangate45/sky130hd. - Shared memory wrapper moved to its platform-neutral home: designs/asap7/ternip/ternip_pipelined_mem_fakeram7.v -> designs/src/ternip/ternip_pipelined_mem_fakeram.v (nangate45/sky130hd were already referencing it cross-platform) - All three cfgs + LEF/LIB renamed and regenerated - asap7 cfg snap keys fixed snake_case -> camelCase (the known silently-ignored-snap bug): macro now on the 0.190/1.400 um site grid (34.560x43.200 -> 34.580x43.400) - nangate45/sky130hd sizes identical; internal PG-strap offsets shift ~1.1 um because the committed LEFs predated the current bsg_fakeram pin (2db2c32) -- pins and size unchanged All three platforms' cached ternip results invalidate and rebuild.
dhgaddy
added a commit
to dhgaddy/HighTide
that referenced
this pull request
Oct 21, 2026
Follow-through on VLSIDA#248, which renamed the shared tc_sram.sv mapping and the asap7/nangate45 macros from fakeram7_* to the platform-neutral fakeram_* prefix. Rename the 4 macros in fakeram_gt2n.cfg and regenerate the gt2n LEF/LIB with tools/regenerate_sram.sh snitch_cluster gt2n. Name changes only, identical otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fakeram7_*to the platform-neutralfakeram_*prefix, suite-wide (sharedtc_sram.svmapping + cfgs + regenerated LEF/LIB on asap7 and nangate45). Prompted by gt2n: port snitch_cluster #240, where the gt2n port inherited the misleading7.fakeram7_512x16→fakeram_512x16, and the shared memory wrapper moves to its platform-neutral homedesigns/src/ternip/ternip_pipelined_mem_fakeram.v(nangate45/sky130hd were referencing it underdesigns/asap7/).dev/generated/fakeram_asap7.cfg, committed LEF/LIB atdesigns/asap7/snitch_cluster/sram/{lef,lib}/, local filegroups like the other platforms; the trackeddev/generated/sram/tree is removed andtools/regenerate_sram.shnow works for both designs on every platform.snap_width_nm→snapWidth_nm, the known silently-ignored-snap bsg_fakeram bug): macros now land exactly on the 0.190/1.400 µm site grid.Verification
2db2c32).wd_inpinsDIRECTION INPUT(post-c83ecb4generator); onlyrd_outis OUTPUT.bazel build --nobuildanalysis passes for all five_synthtargets; nofakeram7references remain underdesigns/.Fallout