Repository navigation
fix: wait for CrowdSec to finish starting before reloading it - #1790
Merged
Merged
Conversation
SafeDep Report SummaryPackage Details
This report is generated by SafeDep GitHub App |
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
✅ Supply Chain Verification Results✅ PASSED 📦 SBOM Summary
🔍 Vulnerability Scan
📎 Artifacts
Generated by Supply Chain Verification workflow • View Details |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Bump gin-contrib/gzip to v1.2.9, gin-contrib/sse to v1.2.0, and pandatix/go-abnf to v0.5.4.
Rebuilds the prebuilt Caddy/CrowdSec toolchain image so the shipped binaries pick up upstream fixes, and bumps the digest pin in the Dockerfile.
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
Makes CrowdSec start, reload and import checks wait for the engine instead of racing it.
crowdsec_engine_exited, reverts the switch and shows a message in the UI.reload_pending(shown as a passive "reload scheduled" note) instead of "reload required".config.yamlneeds aconfig_pathssection, and the engine's own-tcheck must accept it (skipped with a warning if the check cannot run, or when its output points at the environment: busy port or database, missing notification plugins). A failed whitelist regeneration after import now rolls back.Commits
Eight commits plus the QA report: specs, process identity, engine-exit detection, reloader (with frontend), whitelist placeholder, import check, a plugin-aware skip for that check, docs, and review fold-ins.
Testing
security-tests) 62/62, whitelist (firefox) 12/12.config_paths, brokenconfig_dir), SIGHUP pair, decision ban through a proxy host.TestPerf_GetStatus_Parallel_AssertThresholdcan miss its 5 ms threshold under full-package load; passes alone.See
docs/reports/qa_report.md.