Repository navigation
Removes cached file status on error - #6620
Merged
Merged
Conversation
The bulk import code uses cached file status objects to open files. When any error occurs reading a file this change removes the cached file status in case stale information in the file status was causing a problem. This change may fix apache#6617.
keith-turner
commented
Oct 28, 2026
| Collections.synchronizedSortedMap(new TreeMap<>()); | ||
|
|
||
| final Map<Path,FileStatus> fileStatuses = new HashMap<>(); | ||
| final Map<Path,FileStatus> fileStatuses = new ConcurrentHashMap<>(); |
Contributor
Author
There was a problem hiding this comment.
Noticed multiple threads were interacting w/ this map so changed the type to ensure threads see what other threads put in the map.
dlmarion
approved these changes
Oct 29, 2026
ddanielr
approved these changes
Oct 29, 2026
keith-turner
added a commit
that referenced
this pull request
Oct 30, 2026
Changes in #6620 introduced a potential NPE when status is removed from map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bulk import code uses cached file status objects to open files. When any error occurs reading a file this change removes the cached file status in case stale information in the file status was causing a problem. This change may fix #6617.