Repository navigation
Conversation
OwSink.combine in DockerToActivationFileLogStore.scala was adapted from Sink.combine in Akka 2.5.6 (Apache-2.0) when Apache OpenWhisk added it in 2017 (apache/openwhisk d69f8db02). Keep the upstream Lightbend copyright notice alongside the ASF header, as ConcurrentMapBackedCache.scala does for the code it derives from Spray. Part of apache/openserverless#265. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of apache/openserverless#265.
OwSink.combineinopenwhisk/common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/logging/DockerToActivationFileLogStore.scalasays it is "basically copied fromSink.combine". Apache OpenWhisk added it in 2017 (apache/openwhisk@d69f8db02), when it built against Akka 2.5.6. Akka 2.5.6'sSink.scalais Apache-2.0 and carries:The file only had the ASF header. This PR keeps the ASF header and adds the upstream Lightbend notice below it:
This follows the pattern
ConcurrentMapBackedCache.scalaalready uses for the code it derives from Spray.Comment-only change. Akka 2.5.6 ships no
NOTICEfile, so nothing needs to be added toNOTICE. The matching entry in the top-levelLICENSEis apache/openserverless#270.(apache/openserverless#265 has two errors. It gives the Akka version as 2.6.12, which is the version the build uses today, not the one the code was copied from. It also suggests re-deriving from Apache Pekko, but that would not help: Pekko's
Sink.scalastill carries the Lightbend copyright header, so the attribution would be needed either way.)🤖 Generated with Claude Code