Repository navigation
fix(fish): parse the format fish actually writes - #90
Merged
Merged
Conversation
parse_fish_line expected cmd "foo" / when 1700000000 without colons.fish writes YAML-shaped entries: - cmd: <raw text>, when: <unix>, and an optional indented paths: block. So - cmd: git status hit the leading dash, went to parse_fish_yaml_line, which split on '\n' over a single line,found no cmd prefix and returned None. Every fish user saw an empty history. The module's tests were green because all of them asserted the invented format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_fish_line expected cmd "foo" / when 1700000000 without colons.fish writes YAML-shaped entries: - cmd:
, when: , and an optional indented paths: block. So - cmd: git status hit the leading dash,
went to parse_fish_yaml_line, which split on '\n' over a single line,found no cmd prefix and returned None.
Every fish user saw an empty history. The module's tests were green because all of them asserted the invented
format.