Repository navigation
Fix/xdg shell paths - #92
Merged
Merged
Conversation
…ntion history_path() and config_path() hardcoded five paths that the shells themselves resolve through the environment. Anyone who sets $XDG_CONFIG_HOME, $XDG_DATA_HOME or $ZDOTDIR got no history at all, and --worse -- a silent non-install: ctrlr init wrote the integration into a file the shell never loads, Ctrl+R did nothing, and the next ctrlr init read the same wrong file back and reported "up to date". Measured against fish 3.7.0, pwsh and zsh 5.9 rather than taken from the docs: fish history $XDG_DATA_HOME/fish/fish_history fish config $XDG_CONFIG_HOME/fish/config.fish pwsh history $XDG_DATA_HOME/powershell/PSReadLine/ConsoleHost_history.txt pwsh profile $XDG_CONFIG_HOME/powershell/Microsoft.PowerShell_profile.ps1 zsh config $ZDOTDIR/.zshrc With none of those set, all three shells answer with exactly the paths that were hardcoded, so this is a superset and the default case cannot regress.
The "PowerShell hook writes a parseable record" step failed with "the hook wrote nothing". No code was broken; the step was writing outside its ownsandbox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.