Repository navigation
Conversation
The resolved-cache.conf drop-in hardcodes Cache=yes for all stemcells with no operator control. bosh-agent now writes Cache= into its own 10-bosh.conf drop-in (env.bosh.systemd_resolved.cache), defaulting to yes, so the stemcell file is redundant. Remove the asset and the cp line that installs it, and drop the corresponding spec assertion.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
neddp
marked this pull request as ready for review
October 30, 2026 11:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
resolved-cache.confdrop-in hardcodesCache=yesfor all stemcells with no operator control. bosh-agent now writesCache=into its own10-bosh.confdrop-in, defaulting toyes, so the stemcell file is redundant.cloudfoundry/bosh-agent#499
Remove the asset and the cp line that installs it, and drop the corresponding spec assertion.