Repository navigation
refactor(gcs): drop the credentials write mutex - #321
Merged
Merged
Conversation
The WriteFileAtomic function of machinery v0.6.1 names its temporary file with a random suffix, so concurrent writes of the same file no longer collide. This was the condition to remove the mutex, see cloudnative-pg/machinery#325. Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
mnencia
force-pushed
the
dev/drop-google-credentials-mutex
branch
from
October 16, 2026 12:56
cc6506d to
7ca9649
Compare
armru
approved these changes
Oct 16, 2026
leonardoce
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
googleCredentialsMutex. It serialized the writes of the GCS credentials file becauseWriteFileAtomicnamed its temporary file after the current second, so concurrent writes of the same file shared it. machinery v0.6.1 uses a random suffix, which was the condition set in #309 to drop the mutex (cloudnative-pg/machinery#325).