Skip to content

refactor(gcs): drop the credentials write mutex #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnencia merged 1 commit into from
Oct 16, 2026
Merged

refactor(gcs): drop the credentials write mutex #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions pkg/credentials/env.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import (
"context"
"fmt"
"path"
"sync"

machineryapi "github.com/cloudnative-pg/machinery/pkg/api"
"github.com/cloudnative-pg/machinery/pkg/fileutils"
Expand Down Expand Up @@ -328,11 +327,6 @@ func envSetAzureCredentials(
// so tests can change it.
var googleCredentialsDirectory = path.Join(ScratchDataDirectory, ".google-credentials")

// googleCredentialsMutex serializes the writes, because WriteFileAtomic
// names its temporary file after the current second. Remove it once
// cloudnative-pg/machinery#325 is released.
var googleCredentialsMutex sync.Mutex

func envSetGoogleCredentials(
ctx context.Context,
c client.Client,
Expand Down Expand Up @@ -363,8 +357,6 @@ func envSetGoogleCredentials(
googleCredentials.ApplicationCredentials.Key,
)

googleCredentialsMutex.Lock()
defer googleCredentialsMutex.Unlock()
if _, err := fileutils.WriteFileAtomic(credentialsPath, applicationCredentialsContent, 0o600); err != nil {
return nil, err
}
Expand Down
Loading