[shenxianpeng]

Follow-up to #538, as discussed there: --gen-patch-path resolves a relative path against the current working directory, so the other output paths now do the same instead of resolving against --repo-root.

Changes

• FeedbackInput::from(&Cli) makes summary_output_file and sarif_file absolute (against the cwd), sharing a small absolute_or_given() helper with patch_path.
• RestClient::post_feedback() writes to those paths as given (no more repo_root.join()).
• Help text for both options now says a relative path is relative to the current working directory.
• Tests:
  • new unit test relative_output_files (relative paths resolve against the cwd even with --repo-root sub).
  • the relative_out_files integration test now writes into a temp dir made in the cwd and passes a path relative to the cwd.

This changes behavior for anyone passing a relative --summary-output-file/--sarif-file together with a --repo-root that isn't the cwd. I'll note it in the migration guide (#535).

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI (base), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: c2595e42-9ff3-40f3-aec0-5cb3500ade9c

Commits

Reviewing files that changed from the base of the PR and between 6c6c2ee and 4b6302c.

Files selected for processing: 4

• cpp-linter/src/cli/mod.rs
• cpp-linter/src/cli/structs.rs
• cpp-linter/src/rest_client.rs
• cpp-linter/tests/comments.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.82%. Comparing base (940d4b6) to head (4b6302c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #541   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          29       29           
  Lines        7432     7482   +50     
=======================================
+ Hits         7419     7469   +50     
  Misses         13       13           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.