Repository navigation
SAT: use c_enum underlying type signedness for extensions - #9227
Open
tautschnig wants to merge 1 commit into
Open
tautschnig wants to merge 1 commit into
tautschnig wants to merge 1 commit into
Conversation
The SAT back end (boolbv_typecast) treated all c_enum values as signed when extending to wider types: integer-to-integer, integer-to-fixedbv, and integer-to-float conversions all used sign extension for c_enum sources. This is wrong for enums whose underlying type is unsigned (e.g., enums with values > INT_MAX or packed enums with values > 127). Fix: check the c_enum underlying type signedness in all three places instead of unconditionally treating IS_C_ENUM as signed. Fixes diffblue#9206 Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
requested review from
kroening,
martin-cs and
peterschrammel
as code owners
October 20, 2026 19:39
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9227 +/- ##
===========================================
- Coverage 80.91% 80.90% -0.02%
===========================================
Files 1718 1718
Lines 190266 190275 +9
Branches 73 73
===========================================
- Hits 153952 153937 -15
- Misses 36314 36338 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SAT back end (boolbv_typecast) treated all c_enum values as signed
when extending to wider types: integer-to-integer, integer-to-fixedbv,
and integer-to-float conversions all used sign extension for c_enum
sources. This is wrong for enums whose underlying type is unsigned
(e.g., enums with values > INT_MAX or packed enums with values > 127).
Fix: check the c_enum underlying type signedness in all three places
instead of unconditionally treating IS_C_ENUM as signed.
Fixes #9206