Skip to content

SAT: use c_enum underlying type signedness for extensions #9227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tautschnig wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

SAT: use c_enum underlying type signedness for extensions #9227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions regression/cbmc/enum_unsigned_widen/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
enum E
{
A = 0x80000000u,
B = 1
};
enum __attribute__((packed)) P
{
X = 200,
Y = 1
};
enum E nondet_e(void);
enum P nondet_p(void);

int main(void)
{
// enum E has underlying type unsigned int
enum E e = nondet_e();
__CPROVER_assume(e == A || e == B);
long long l = e;
__CPROVER_assert(l > 0, "unsigned enum widened is positive");

// enum P has underlying type unsigned char
enum P p = nondet_p();
__CPROVER_assume(p == X);
int i = p;
__CPROVER_assert(i == 200, "packed unsigned enum converts correctly");
return 0;
}
8 changes: 8 additions & 0 deletions regression/cbmc/enum_unsigned_widen/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
CORE broken-cprover-smt-backend gcc-only
main.c

^EXIT=0$
^SIGNAL=0$
^VERIFICATION SUCCESSFUL$
--
^warning: ignoring
22 changes: 19 additions & 3 deletions src/solvers/flattening/boolbv_typecast.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,24 @@ bool boolbvt::type_conversion(
break;

case bvtypet::IS_SIGNED: // signed to float
case bvtypet::IS_C_ENUM:
float_utils.spec = ieee_float_spect(to_floatbv_type(dest_type));
dest = float_utils.from_signed_integer(src);
return false;

case bvtypet::IS_C_ENUM: // enum to float
float_utils.spec = ieee_float_spect(to_floatbv_type(dest_type));
if(
src_type.id() == ID_c_enum &&
to_c_enum_type(src_type).underlying_type().id() == ID_unsignedbv)
{
dest = float_utils.from_unsigned_integer(src);
}
else
{
dest = float_utils.from_signed_integer(src);
}
return false;

case bvtypet::IS_UNSIGNED: // unsigned to float
case bvtypet::IS_C_BOOL: // _Bool to float
float_utils.spec = ieee_float_spect(to_floatbv_type(dest_type));
Expand Down Expand Up @@ -298,7 +311,8 @@ bool boolbvt::type_conversion(
{
if(
src_bvtype == bvtypet::IS_SIGNED ||
src_bvtype == bvtypet::IS_C_ENUM)
(src_bvtype == bvtypet::IS_C_ENUM && src_type.id() == ID_c_enum &&
to_c_enum_type(src_type).underlying_type().id() != ID_unsignedbv))
l = src[src_width - 1]; // sign extension
else
l = const_literal(false); // zero extension
Expand Down Expand Up @@ -381,7 +395,9 @@ bool boolbvt::type_conversion(
// destination type.
// E.g., ((short)(ulong)(short)-1)==-1
bool sign_extension =
src_bvtype == bvtypet::IS_SIGNED || src_bvtype == bvtypet::IS_C_ENUM;
src_bvtype == bvtypet::IS_SIGNED ||
(src_bvtype == bvtypet::IS_C_ENUM && src_type.id() == ID_c_enum &&
to_c_enum_type(src_type).underlying_type().id() != ID_unsignedbv);

for(std::size_t i = 0; i < dest_width; i++)
{
Expand Down
Loading