Repository navigation
Publish the website in Russian, Ukrainian, Japanese, Korean and both Chinese editions - #88
Merged
donislawdev merged 6 commits intoOct 21, 2026
Conversation
Twelve pages and the chrome file for Russkij, with the English addresses (the registry marks Cyrillic languages as english-slug). The strict build with --require-fresh passes, and no page overflows horizontally at 375 or 1024 px. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Twelve pages and the language file for uk, listed after Turkish and before Vietnamese. The pages live at the English slugs under /uk/, since Cyrillic cannot be an ASCII address without transliteration. The strict build with --require-fresh reports no problems, and none of the eleven pages or the 404 overflows horizontally at 375 or 1024 px. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Twelve pages and the language file for ja, listed after Italian and before Dutch. The pages live at the English slugs under /ja/. The strict build with --require-fresh reports no problems, none of the eleven pages or the 404 overflows horizontally at 375 or 1024 px, and the Japanese font stack and line height already in style.css apply (checked on the rendered home page). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Twelve pages and the language file for ko, listed after Japanese and before Dutch. The pages live at the English slugs under /ko/. The strict build with --require-fresh reports no problems and none of the eleven pages or the 404 overflows horizontally at 375 or 1024 px. style.css gains one rule, word-break: keep-all for Korean. Without it the browser splits Korean words in half at the end of every line (seen on the home page headline), and with it the lines break at the spaces. All twelve pages were measured again after the rule was added. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Twelve pages and the language file for zh-hans, listed after Vietnamese. The pages live at the English slugs under /zh-hans/. The strict build with --require-fresh reports no problems, none of the eleven pages or the 404 overflows horizontally at 375 or 1024 px, and the Simplified Chinese font stack from style.css applies. Three meta descriptions were lengthened to reach the 50 character minimum, which counts characters and so is easier to miss in Chinese than elsewhere. The heading of the sc.exe page puts a space and a conjunction between its two code spans, because the ideographic comma between two non-wrapping spans left no place to break and pushed that page 13 px wider than a phone at 375 px. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Twelve pages and the interface strings in Traditional Chinese, written with Taiwanese vocabulary rather than converted from the Simplified edition, and enabled in site.json. The addresses stay the English ones, because the script cannot be an ASCII address. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 80
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Publishes the website in six more languages, the first ones that are not written in the Latin script: Russian, Ukrainian, Japanese, Korean, Simplified Chinese and Traditional Chinese.
This PR is stacked on #87 (
feature/site-languages-batch-2, itself stacked on #86), so its base is that branch and the diff shows only this batch. When the earlier PRs are merged, GitHub retargets this one tomain.languagesinsite/site.json./ru/,/ja/..., and so on), because a script that is not Latin cannot be an ASCII address. The generator already refuses aslugentry for such a language, so no page carries one.{{...}}tokens.site/assets/style.css:html:lang(ko) { word-break: keep-all; }. Without it the browser split Korean words in half at the end of a line, which showed on the home page headline. The font stacks and line heights for Japanese, Korean and Chinese were already in the stylesheet from Prepare the website for twenty more languages #85.Checked
--require-freshat this tip: 228 pages, no problems.langattribute iszh-Hansandzh-Hantfor the two Chinese editions, and the CJK font stack is the one that applies on those pages.Not checked
word-break: auto-phraseis not used), so a long one can wrap in the middle of a word.Bws.Site.Testsand the mutation entries were not re-run for this PR. CI runs them.🤖 Generated with Claude Code