Repository navigation
Preserve Nexus Avro arguments through runtime payload transport - #396
Conversation
|
Reviewed 068a943 against main 3278ef8. The change reuses namespace-scoped transport and the existing Avro resolver. Inline bytes remain unchanged, external bytes are validated and retained without reupload, and serialized arguments also reach workflow command bindings through All six new HTTP regressions and the normal PHP feature/Nexus/source-contract/boundary suite pass in run 38127627069. Superseded own run 38127556538 is confirmed cancelled. This merge changes no native/shared fixture/spec, default execution model, dependency or version. Published delivery remains under #395, with the actual caller suite #394 and linked terminal lifecycle durable-workflow/workflow#753 still open. |
|
Acknowledged the planned Server 2.5.21 / Helm 0.1.158 delivery for #396. The native #325 follow-through is draft #399, isolated on the same The first native candidate compiled but failed two new test assertions, so it remains unqualified. Current source |
rmcdaniel
left a comment
There was a problem hiding this comment.
Reviewed final f42a621569ce2b368a20336f80093d469014b53f against current main b70ba209384a0959e2c61598c1f8e5bd08c14d9f, tree 3638ba1ba6037e592d918950309bf57912efa2a9.
Checked Avro validation before dispatch, namespace-specific runtime reference resolution, immutable external retention without another upload, and both workflow-start and command argument forwarding. Existing raw argument arrays keep their established path. Unsupported codecs and foreign namespace references retain their current rejection boundaries.
Checked the six focused HTTP cases plus the official codec fixture and defect-specific counterfactual adapter. Required feature/Nexus/corpus tests must pass on this final head, including the proof failing when this controller is restored to its base implementation. No blocking source finding. This diff does not change native implementation, shared contracts, migrations or dependencies.
Publication and installed consumer qualification are still required before #395 closes. Broader Nexus terminal recovery is separate in Workflow #753.
rmcdaniel
left a comment
There was a problem hiding this comment.
Reviewed final 141c4ac9e5cbda6c86e0a1fc29a511c821eac556 against main b70ba209384a0959e2c61598c1f8e5bd08c14d9f, tree 71ae2f694f14ca0188a95033d41767a147db8a5a.
Checked namespace-scoped external reference resolution/retention, Avro validation before dispatch, and serialized argument forwarding for both workflow starts and command handlers. Existing raw array behavior remains. Seven focused tests pass, and the official fixture/current/base/controller-only reversion proof passes on application source c34523797, which is byte-identical to this final application/test source. Published 2.5.20 + installed Python2.6.0rc1 reproduces the external input defect after completing its inline case.
Checked generated Server2.5.21 / Helm0.1.158 defaults and lock consistency. Only the Composer content hash changes; every dependency object stays identical, including published Workflow2.5.10 / 52e810c. No native/shared-contract/migration changes.
No blocking diff finding. Final exact-head source/chart/topology gates remain required before merge, followed by immutable publication and actual published consumers before #395 closes.
Fix and release
Addresses #395, which stays open through published consumer qualification.
Resolve Nexus argument envelopes with the existing Avro resolver and namespace runtime storage. Retain immutable external bytes without another upload. Preserve the serialized blob for workflow starts and command bindings, and reject malformed input before dispatch.
Final candidate
141c4ac9e5cbda6c86e0a1fc29a511c821eac556, tree71ae2f694f14ca0188a95033d41767a147db8a5a, is based on Server mainb70ba209384a0959e2c61598c1f8e5bd08c14d9f. Seven focused HTTP tests and the official codec counterfactual proof pass locally on its identical application/test source. The new fixture passes with the corrected controller and fails with the base controller. Exact published Server 2.5.20 with installed Python 2.6.0rc1 completes the inline service workflow, then reproduces external arguments arriving as None.Includes generated Server 2.5.21 / Helm 0.1.158 defaults. Workflow remains published 2.5.10 /
52e810c7971d0af9907f2d59b349efedd43e7749. All dependency package objects remain unchanged, with only Composer's content hash regenerated. No native implementation, shared PHP/Rust/embedded contract or migration changes.Normal source, chart and topology checks must pass on this final head. After merge, publish both architectures, verify exact registry identities, run published PHP/Python/Rust lifecycle and Compose gates, and repeat the installed Python input/completion check against the new digest. Broader durable caller terminal convergence remains in Workflow #753 and Server #394.