fix: apply agentic workflow outcome labels instead of suggestions - #4824
Merged
Merged
Conversation
Disable suggestion handling for assigned outcome labels in all seven labeling workflows. Preserve existing validation and cleanup behavior, regenerate compiled workflows, and cover source, agent, and handler settings. Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Source and compiled settings agree, existing safeguards remain intact, and regression coverage and inspected live-run logs support the fix.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes suggestion-only labeling across Spec Kit’s seven label-producing agentic workflows, addressing the behavior reported for #4817.
Changes:
- Disables issue-intent handling so label requests apply labels.
- Clarifies agent labeling responsibilities while preserving outcome rules.
- Regenerates compiled workflows and adds configuration regression coverage.
Validation used regression assertions and linked handler logs; tests were not rerun during this review.
| File | Description |
|---|---|
| tests/test_github_workflows.py | Checks label application settings and prompt contracts. |
| .github/workflows/feature-assess.md | Requires feature outcome label application. |
| .github/workflows/feature-assess.lock.yml | Updates compiled feature labeling configuration. |
| .github/workflows/bug-test.md | Requires test outcome label application. |
| .github/workflows/bug-test.lock.yml | Updates compiled test labeling configuration. |
| .github/workflows/bug-fix.md | Requires fix outcome label application. |
| .github/workflows/bug-fix.lock.yml | Updates compiled fix labeling configuration. |
| .github/workflows/bug-assess.md | Requires assessment label application. |
| .github/workflows/bug-assess.lock.yml | Updates compiled assessment labeling configuration. |
| .github/workflows/add-community-preset.md | Requires preset validation label application. |
| .github/workflows/add-community-preset.lock.yml | Updates compiled preset labeling configuration. |
| .github/workflows/add-community-extension.md | Requires extension validation label application. |
| .github/workflows/add-community-extension.lock.yml | Updates compiled extension labeling configuration. |
| .github/workflows/add-community-bundle.md | Requires bundle validation label application. |
| .github/workflows/add-community-bundle.lock.yml | Updates compiled bundle labeling configuration. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apply assigned outcome labels instead of allowing suggestion-only completion in all seven label-producing agentic workflows: community extension, preset, and bundle submission; bug assessment, fixing, and testing; and feature assessment.
Set
safe-outputs.add-labels.issue-intent: false, clarify the agent's labeling responsibility, regenerate the seven compiled workflows withgh-awv0.88.7, and add regression coverage for both agent-facing and handler configuration. Existing validation outcomes, blocked-validation rules, label cleanup, permissions, and label allowlists remain unchanged.In the reported workflow run for github/spec-kit#4817, the handler reported zero labels added and one label suggested, although the workflow completed successfully. Disabling issue-intent handling makes structured label requests use actual label application, including requests carrying
suggest: true.Testing
uv run specify --helpuv sync && uv run pytestThe existing-tests checklist is satisfied by the fork CI commands
uv sync --extra testfollowed byuv run pytest. Local tests use this worktree's virtualenv interpreter, as recommended in CONTRIBUTING.md. Sample-project slash-command testing is not applicable: no CLI implementation, command templates, integration files, or workflow scripts changed.uv run specify --help.venv\Scripts\python.exe -m pytest tests\test_github_workflows.py -quv sync --extra test, thenuv run pytest(run)The full local suite was not rerun; full-suite evidence is from fork CI. The live runs used fork main commit
a45cff0b, whose complete tree matches this PR's head commitcb7ef448.Test selection reasoning
.lock.ymlfilestests/test_github_workflows.pyLive issue-triggered results
Each counted run applied the expected label, removed the stale opposite validation label, and preserved the unrelated
enhancementlabel. Verification checked actual source-issue labels and handler logs, not just green workflow jobs.validation-passedvalidation-failedTwo preliminary attempts had incorrect fixture trigger labels and are excluded from these results; the labels were corrected before the final counted runs. All six test issues were subsequently closed and test labels removed. Both generated catalog PRs were closed without merging their changes.
Coverage limitations: bug/feature workflows have regression and pinned-handler coverage, but were not live issue-triggered in this round. Blocked-validation behavior has local and handler/API coverage, but no full issue-triggered blocked run was forced.
AI Disclosure
AI disclosure: GitHub Copilot (model: GPT-6.1 Sol) acted on behalf of @KSchlobohm with autonomous execution, human-directed scope, and human publication approval; the session's reasoning-effort setting is not exposed. AI assistance covered investigation, workflow and test changes, generated lockfiles, self-review, test-fixture preparation, verification, and this PR text. The linked live tests executed the repository-configured GitHub Copilot workflow engine (model: gpt-5.2-codex, automated execution); its temporary catalog changes were not merged into this contribution.