Repository navigation
ci: add shared release fix notifications - #65
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAdds a workflow for published releases and manual dispatch. It passes the selected tag, the ChangesRelease Fix Comments
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The change adds a release-notification workflow with pinned dependency and scoped permissions. No concrete merge-blocking defect is established, though the author says it is a draft and should not merge until the shared dependency review is settled. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| uses: jdx/workflows/.github/workflows/comment-release-fixes.yml@4c952564543dd54d60f15ef4062af7fb60c5561d | ||
| with: | ||
| tag: ${{ needs.create-release.outputs.revision_tag }} | ||
| tag_pattern: '^[0-9]+\.[0-9]+\.[0-9]+-[0-9]+$' |
There was a problem hiding this comment.
Prerelease revision tags fail pattern
Medium Severity
The new tag_pattern only accepts X.Y.Z-N tags, but create-release always builds revision_tag as VERSION plus a numeric suffix. Preview and rc versions therefore produce tags that do not match, so the publication-path notification job will not process those releases.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 0f1135f. Configure here.
|
| uses: jdx/workflows/.github/workflows/comment-release-fixes.yml@4c952564543dd54d60f15ef4062af7fb60c5561d | ||
| with: | ||
| tag: ${{ needs.create-release.outputs.revision_tag }} | ||
| tag_pattern: '^[0-9]+\.[0-9]+\.[0-9]+-[0-9]+$' |
There was a problem hiding this comment.
Prerelease fixes get no comments
Both callers set tag_pattern to accept only stable versions, but this repository also publishes previews and release candidates. For example, 4.0.0-preview3 produces 4.0.0-preview3-1, which this pattern rejects. That excludes supported prerelease builds from fix notifications, including manual recovery runs. Allow preview and rc suffixes here and in .github/workflows/comment-release-fixes.yml.
Knowledge Base Used: Release workflows
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 78704cf. Configure here.


Summary
Add shared release-fix notifications through jdx/workflows, with a manual dry-run/recovery entry point.
Use the shared release-notification workflow for this project's publication flow.
Dependency and validation
Depends on jdx/workflows#4 and pins its implementation by immutable SHA. This is a draft rollout PR: shared-code safety review and project-specific publication-path validation are still in progress. No live notification dispatch or historical backfill is part of this PR. Do not merge until the shared dependency and relevant checks are settled.
Note
Low Risk
CI-only automation that posts issue/PR comments after a successful release; no application or binary behavior changes.
Overview
Wires release-fix notifications into the publish pipeline by calling the pinned shared
jdx/workflowscomment-release-fixesworkflow afterpublish-releasesucceeds, using the immutable revision tag fromcreate-releaseand theruby-fixed-inmarker prefix with aX.Y.Z-Ntag pattern.Adds a manual
comment-release-fixesworkflow so operators can run the same logic for a given revision tag, withdry_rundefaulting to true so comments can be validated without posting.Reviewed by Cursor Bugbot for commit 7ff5fce. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit