Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/comment-release-fixes.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: comment release fixes

on:
workflow_dispatch:
inputs:
tag:
description: Immutable Ruby build revision, for example 4.0.7-2
required: true
type: string
dry_run:
required: false
type: boolean
default: true

jobs:
comment:
permissions:
contents: read
pull-requests: read
issues: write
discussions: write
uses: jdx/workflows/.github/workflows/comment-release-fixes.yml@4c952564543dd54d60f15ef4062af7fb60c5561d # v1.1.0
with:
tag: ${{ inputs.tag }}
tag_pattern: '^[0-9]+\.[0-9]+\.[0-9]+-[0-9]+$'
marker_prefix: ruby-fixed-in
dry_run: ${{ inputs.dry_run || false }}
14 changes: 14 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,20 @@ jobs:
# Publish pinned revision release
gh release edit "${REVISION_TAG}" --draft=false --latest=false $prerelease_flag --repo "${{ github.repository }}"

comment-release-fixes:
needs: [create-release, publish-release]
if: ${{ needs.publish-release.result == 'success' }}
permissions:
contents: read
pull-requests: read
issues: write
discussions: write
uses: jdx/workflows/.github/workflows/comment-release-fixes.yml@4c952564543dd54d60f15ef4062af7fb60c5561d # v1.1.0
with:
tag: ${{ needs.create-release.outputs.revision_tag }}
tag_pattern: '^[0-9]+\.[0-9]+\.[0-9]+-[0-9]+$'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prerelease revision tags fail pattern

Medium Severity

The new tag_pattern only accepts X.Y.Z-N tags, but create-release always builds revision_tag as VERSION plus a numeric suffix. Preview and rc versions therefore produce tags that do not match, so the publication-path notification job will not process those releases.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0f1135f. Configure here.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Prerelease fixes get no comments

Both callers set tag_pattern to accept only stable versions, but this repository also publishes previews and release candidates. For example, 4.0.0-preview3 produces 4.0.0-preview3-1, which this pattern rejects. That excludes supported prerelease builds from fix notifications, including manual recovery runs. Allow preview and rc suffixes here and in .github/workflows/comment-release-fixes.yml.

Knowledge Base Used: Release workflows

Fix in Claude Code

marker_prefix: ruby-fixed-in

notify:
needs: [build, combine-hashes, create-release, provenance, upload-assets, publish-release]
runs-on: ubuntu-latest
Expand Down
Loading