Repository navigation
ci: add shared release fix notifications #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
db94182
162674d
74520fb
cd14f6f
0f1135f
78704cf
7ff5fce
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| name: comment release fixes | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| tag: | ||
| description: Immutable Ruby build revision, for example 4.0.7-2 | ||
| required: true | ||
| type: string | ||
| dry_run: | ||
| required: false | ||
| type: boolean | ||
| default: true | ||
|
|
||
| jobs: | ||
| comment: | ||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
| issues: write | ||
| discussions: write | ||
| uses: jdx/workflows/.github/workflows/comment-release-fixes.yml@4c952564543dd54d60f15ef4062af7fb60c5561d # v1.1.0 | ||
| with: | ||
| tag: ${{ inputs.tag }} | ||
| tag_pattern: '^[0-9]+\.[0-9]+\.[0-9]+-[0-9]+$' | ||
| marker_prefix: ruby-fixed-in | ||
| dry_run: ${{ inputs.dry_run || false }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -268,6 +268,20 @@ jobs: | |
| # Publish pinned revision release | ||
| gh release edit "${REVISION_TAG}" --draft=false --latest=false $prerelease_flag --repo "${{ github.repository }}" | ||
|
|
||
| comment-release-fixes: | ||
| needs: [create-release, publish-release] | ||
| if: ${{ needs.publish-release.result == 'success' }} | ||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
| issues: write | ||
| discussions: write | ||
| uses: jdx/workflows/.github/workflows/comment-release-fixes.yml@4c952564543dd54d60f15ef4062af7fb60c5561d # v1.1.0 | ||
| with: | ||
| tag: ${{ needs.create-release.outputs.revision_tag }} | ||
| tag_pattern: '^[0-9]+\.[0-9]+\.[0-9]+-[0-9]+$' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Both callers set Knowledge Base Used: Release workflows |
||
| marker_prefix: ruby-fixed-in | ||
|
|
||
| notify: | ||
| needs: [build, combine-hashes, create-release, provenance, upload-assets, publish-release] | ||
| runs-on: ubuntu-latest | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prerelease revision tags fail pattern
Medium Severity
The new
tag_patternonly acceptsX.Y.Z-Ntags, butcreate-releasealways buildsrevision_tagasVERSIONplus a numeric suffix. Preview and rc versions therefore produce tags that do not match, so the publication-path notification job will not process those releases.Additional Locations (1)
.github/workflows/comment-release-fixes.yml#L24-L25Reviewed by Cursor Bugbot for commit 0f1135f. Configure here.