Repository navigation
fix: redact session identities and quote callback logs - #16
Merged
Merged
Conversation
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order: #16, #17, #18, then #19.
Auth debug logs use
session_prefix, the first four characters of the JaWS session cookie, to correlate sessions with browser cookies. Cookies shorter than 12 characters have no logged prefix, leaving at least eight base-32 characters undisclosed. The prefix exposes up to 20 bits of the 64-bit random session ID.OAuth2 callback error fields remain untrusted browser input and preserve the provider's text. The demo quotes errors when logging, and
FailedFuncdocumentation tells applications to quote logged errors and escape rendered output.Validation:
go test -race ./...,go vet ./...,go build ./...,golangci-lint run, andgosec ./...in both Go modules. Localstaticcheck ./...reportedmatched no packagesin both modules.Closes #11
Closes #13