Repository navigation
fix: bound login redirects and handle session limits - #17
Merged
Merged
Conversation
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cookie-less requests at a JaWS session limit return 503 with
Retry-After: 60instead of redirecting back to the protected route. Login owns session creation, eliminating the wrapper's duplicate attempt.Return targets normalize leading slash/backslash combinations and fall back to
/above 8192 bytes. An 8000-byte path remains usable, while session storage and final redirects stay bounded. Reverse proxies may need larger upstream response-header buffers for redirects near this limit.Validation:
go test -race ./...,go vet ./...,go build ./...,golangci-lint run, andgosec ./...in both Go modules. Localstaticcheck ./...reportedmatched no packagesin both modules. Regression coverage includes global/per-IP limits, shutdown, both admin and ordinary wrappers, target boundaries, and Referer/RequestURI inputs.Closes #12
Closes #14
Closes #15