Repository navigation
fix(cli): pin elkjs exactly so a CLI version always lays out the same - #65
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🎉 This PR is included in version 0.6.1-rc.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Merged
Contributor
|
🎉 This PR is included in version 0.6.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
deliverpromises the same file byte for byte for the same JSON, and the skill pins an exact CLI version. But the CLI's one runtime dependency,elkjs, was^0.12.0, and npm users don't get our lockfile. Once elkjs ships a 0.12.x patch, the same CLI version could lay out differently depending on install date.Both
packages/cliandpackages/layoutnow pinelkjsto0.12.0. A test inskill.test.tsfails if the CLI's spec stops being exact or drifts from the layout package's.bun.lockchanges only in those two spec lines.How it was checked
bun install --frozen-lockfilepasses.bun run test,bun run typecheck,bun run buildand the deliver determinism smoke pass.