Skip to content

fix(cli): pin elkjs exactly so a CLI version always lays out the same #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyamero merged 1 commit into from
Oct 24, 2026
Merged

fix(cli): pin elkjs exactly so a CLI version always lays out the same #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"prepack": "bun run build && node scripts/prepack.mjs"
},
"dependencies": {
"elkjs": "^0.12.0"
"elkjs": "0.12.0"
},
"devDependencies": {
"@playwright/test": "^1.63.0",
Expand Down
7 changes: 7 additions & 0 deletions packages/cli/test/skill.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ describe('skill ↔ CLI version', () => {
});

describe('package.json', () => {
it('pins elkjs exactly, and to the version the layout package uses, so a CLI version always gives the same layout', () => {
const dep = (p: string) => (JSON.parse(readFileSync(new URL(p, import.meta.url), 'utf8')) as { dependencies: Record<string, string> }).dependencies.elkjs;
const cli = dep('../package.json');
expect(cli).toMatch(/^\d+\.\d+\.\d+$/);
expect(dep('../../layout/package.json')).toBe(cli);
});

it('names every diagram kind in its npm keywords, so a search for any of them finds the package', () => {
const { keywords } = JSON.parse(readFileSync(new URL('../package.json', import.meta.url), 'utf8')) as { keywords: string[] };
for (const kind of DIAGRAM_KINDS) expect(keywords, kind).toContain(kind);
Expand Down
2 changes: 1 addition & 1 deletion packages/layout/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
},
"dependencies": {
"@stackmap/core": "workspace:*",
"elkjs": "^0.12.0"
"elkjs": "0.12.0"
}
}
Loading