Repository navigation
[CodeQuality] Cheap instanceof guard before getType() in BooleanNotIdenticalToNotIdenticalRector - #8539
Merged
Conversation
…enticalToNotIdenticalRector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
processIdentical(), the rule computedgetType()on both sides of every===node before checking the only structural precondition it needs -$identical->left instanceof BooleanNot. So for every identical comparison in a codebase whose left side is not aBooleanNot(the vast majority), it paid two full type inferences and then returned null.Moving the cheap
instanceofguard to the top makesgetType()run only on the!$a === $bshape the rule can actually rewrite. Behavior is unchanged - whenleftis not aBooleanNotthe old code also returned null, and the two type checks are independent conjuncts, so order does not affect the result.