Skip to content

[CodeQuality] Cheap instanceof guard before getType() in BooleanNotIdenticalToNotIdenticalRector #8539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 8, 2026
Merged

[CodeQuality] Cheap instanceof guard before getType() in BooleanNotIdenticalToNotIdenticalRector #8539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions rules/CodeQuality/Rector/Identical/BooleanNotIdenticalToNotIdenticalRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,20 +95,19 @@ public function refactor(Node $node): ?Node

private function processIdentical(Identical $identical): ?NotIdentical
{
$leftType = $this->getType($identical->left);
if (! $leftType->isBoolean()->yes()) {
// cheap structural guard first, so getType() runs only on the "!$a === $b" shape
if (! $identical->left instanceof BooleanNot) {
return null;
}

$rightType = $this->getType($identical->right);
if (! $rightType->isBoolean()->yes()) {
if (! $this->getType($identical->left)->isBoolean()->yes()) {
return null;
}

if ($identical->left instanceof BooleanNot) {
return new NotIdentical($identical->left->expr, $identical->right);
if (! $this->getType($identical->right)->isBoolean()->yes()) {
return null;
}

return null;
return new NotIdentical($identical->left->expr, $identical->right);
}
}
Loading