Repository navigation
chore(renovate): house Python preset, and hold mcp below 2 - #51
Conversation
#48 capped mcp at <2 in pyproject.toml because the server imports mcp.server.fastmcp, which mcp 2.x removed. Renovate then opened #50 (mcp >=2.3,<3), whose Test job fails at import: "No module named 'mcp.server.fastmcp'. This is mcp 2.x, where FastMCP was renamed to MCPServer". A packageRules hold keeps Renovate from proposing 2.x until the server is migrated. Also switches the base from config:recommended to the house preset github>rishitank/.github:python, as the other repos already use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012rYJxu978iUSGFZ1UuqTsi
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. Summary by CodeRabbit
WalkthroughThe Renovate configuration now extends the Python preset and adds a package rule that allows ChangesRenovate configuration
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Merge Risk: ⚪ Minimal · up to The configuration prevents Renovate from moving 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Apprentice, the preset has changed its course Comment |
rishitank
left a comment
There was a problem hiding this comment.
Self-review by Claude
Checked: renovate.json (bb5f9cf). It extends the house preset github>rishitank/.github:python and adds a packageRules hold on mcp <2, because mcp v2 removes mcp.server.fastmcp (Renovate #50 failed Test with No module named 'mcp.server.fastmcp' and is now closed). The config passes renovate-config-validator, and all checks are green.
Follow-up for Rishi: lift the hold once animawatch is ported to the mcp v2 server API.
Why
Follow-up from the self-review of #48.
mcp 2 hold. ci: add shared security scan and actionlint #48 capped
mcpat<2inpyproject.toml, becausesrc/animawatch/server.pyimportsmcp.server.fastmcp, which mcp 2.x removed. Renovate then opened fix(deps): update dependency mcp to v2 #50 (mcp>=2.3,<3), and its Test job fails at collection:Without a Renovate rule it will keep proposing 2.x. The migration (FastMCP to MCPServer plus the other v2 API changes) is a real port of the server, so it is left for a deliberate PR rather than done inside a dependency bump.
House preset.
renovate.jsonstill extended plainconfig:recommended. ci: add shared security scan and actionlint #48 added the shared security and actionlint workflows but missed the switch togithub>rishitank/.github:python, which the other repos use.What changed
renovate.jsononly:extends: ["github>rishitank/.github:python"];packageRulesentry holdingmcpatallowedVersions: "<2", with the reason and the migration guide link.Validated with
renovate-config-validator. The house preset groups GitHub Actions bumps into one PR, so the single-action PRs #41 to #47 will be replaced by that group.#50 is closed with a pointer here.
🤖 Generated with Claude Code
https://claude.ai/code/session_012rYJxu978iUSGFZ1UuqTsi