Repository navigation
Conversation
- One sleep read for the night and the strip of nights, so a delete or a restore changes both in the same state (DeletedNightStateTest on CI) - Mind and body: a paused quiet screen shows Resume, not a dead Pause - Backup: badges, past weeks, saved workouts, exercises and rounds - Personal bests: a lift typed in another case still beats its best - Game summary: periods named from how the game was set up - Sleep edits: resolved among neighbouring sessions, so editing one nap can't overwrite the next one's edit - Times sheet: checks overlaps against every sleep around the day - Zone ranges read again after the zones are moved - Start on your usual: no kcal goal Ready wouldn't offer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Closing in favour of #25, which contains this branch's commit and the rest of the review fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for #21 (develop into main), from a review of the whole develop diff.
CI failure
DeletedNightStateTestfailed on CI.DayViewModelread sleep through two separate Room flows, one for the night and one for the strip of nights. After a delete or a restore they could update one after the other, and the test caught the state in between. Now one read feeds both, so they always change together.Bugs
Not in this PR
MainActivity, which is a bigger change.Testing
./gradlew :protocol:test :app:testDebugUnitTestin UTC: 1182 tests, 0 failed, 1 skipped.assembleDebugandassembleReleaseboth build.🤖 Generated with Claude Code