[sayed0am]

Fixes for #21 (develop into main), from a review of the whole develop diff. It now includes everything from #24, which is closed in favour of this one.

CI failure

DeletedNightStateTest failed on CI. DayViewModel read sleep through two separate Room flows, one for the night and one for the strip of nights. After a delete or a restore they could update one after the other, and the test caught the state in between. Now one read feeds both, so they always change together.

Bugs

• Mind and body: a paused quiet screen showed a Pause button that did nothing. It now shows Resume.
• Backup: badges, past weeks, saved workouts, exercises and workout rounds weren't backed up. They are now restored whole. An exercise already on the phone keeps its own last weight, and restoring twice adds nothing.
• Personal bests: a lift typed in another case ("bench press" against "Bench press") wasn't reported as a new best.
• Game summary: periods were named from how many were played. A quarters game ended after two read "1st half, 2nd half". They're now named from the game's setup, in the live screen's wording.
• Sleep edits: an edit was resolved against the one session alone, so editing or deleting a nap could overwrite the edit of a nap next to it. It's now resolved among nearby sessions, as the screens do.
• Sleep times sheet: the overlap check only saw the day's naps. It now checks every sleep around the day, including last evening's nap.
• Zone ranges: they now read again after the zones are moved on the Heart rate zones page.
• Start on your usual: it could start a kcal goal that Ready no longer offers.
• Folded phone (split view): each workout kind now gets its own live screen there too, so HIIT and run reps keep Skip and +10 s, and games keep Half time.
• Half folded like a laptop: the half under the fold is short, and the full layouts overflowed it. HIIT's seconds sat on the buttons, a run lost its pace and distance, and strength and yoga lost their controls. Below 480 dp the live screens are now compact, and the map and yoga leave out the heart rate the other half already shows.
• Weekly recap: rewards are refreshed before the recap reads the weeks, so it no longer sends stale numbers.
• On the unfolded screen:
  • The workout glow no longer ends in a straight line.
  • Glow cards no longer flash their flat colour when they resize.
• Route map: a run that went nowhere no longer shows a world map.

Speed

• Route smoothing and rep metres are cached, so the route maths no longer runs several times a second.
• Live screens read the ticking time only in the text that shows it.
• Rewards keep the days they read and write only what changed.
• The strength peak uses a binary search, and sleep stages are read once per night.

Unfolded layouts

• Start a workout shows the rest of the sports beside the tiles.
• Activity's Start card fills the width with sports, centred.

Shared code

• One lit heart rate pill, and the same words when there's no reading.
• One max heart rate source.
• One set of summary facts for the share card and the summary.
• PlanChoice for the plan cards.
• TypedValue for Ready's distance goal.
• RoundIcon, the MinusPlus stepper, topHairline and clock().

Cleanup

• About 600 lines of dead code removed: the old split view, unreachable branches, and functions nothing called, along with tests that only covered them.
• All 8 compiler warnings are fixed.

Testing

• TZ=UTC ./gradlew :protocol:test :app:testDebugUnitTest :app:assembleDebug :app:assembleRelease passes.
• New tests cover the backup tables, the lift case, early-ended games, the neighbouring nap edit, the kcal goal and the route map rule.
• Checked on the Galaxy Fold:
  • Unfolded: a run, its map page and its summary, and a HIIT, live and paused.
  • Unfolded: Start a workout, Activity's Start card and the Steps detail glow.
  • Folded: a strap workout's page.
  • Half folded like a laptop: HIIT (work, rest and done), a run (pace and map), strength (ready, set, log and rest), basketball, cross-training and yoga.
  • Half folded like a book: a run (pace and map) and a HIIT. The heart card's zone edge was a hard line on the tall card, now a soft fade.

🤖 Generated with Claude Code