Repository navigation
Refactor scip.pxi file to reduce code duplication - #1284
Merged
Merged
Conversation
adamj34
marked this pull request as ready for review
October 31, 2026 18:57
Contributor
Author
|
Do we want to update CHANGELOG.md for this one? I'm not sure it makes sense to mention internal changes there. |
Member
|
And I agree that this doesn't need to go to the CHANGELOG :) |
adamj34
commented
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces 5 private helper function:
Everything should stay the same from the functional standpoint. The only exceptions are
getDualfarkasLinearandgetDualfarkasKnapsackfunctions, which now additionally perform a constraint type check.