Skip to content

Refactor scip.pxi file to reduce code duplication #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joao-Dionisio merged 4 commits into from
Nov 1, 2026
Merged

Refactor scip.pxi file to reduce code duplication #1284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8c0821
extract duplicated code blocks to helper functions
adamj34 Oct 31, 2026
92d2351
generalize _getTransformedCons function
adamj34 Oct 31, 2026
418fa34
update docstrings
adamj34 Nov 1, 2026
823e876
Improve error message for invalid event handler type
adamj34 Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/pyscipopt/scip.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2330,6 +2330,12 @@ cdef class Model:
cdef _getOrCreateCons(self, SCIP_CONS* scip_cons)
cdef _getOrCreateVar(self, SCIP_VAR* scip_var)
cdef _free_scip_instance(self)

cdef _ensureFreshBestSol(self)
cdef SCIP_CONS* _getTransformedCons(self, Constraint cons, str expected_cons_type)
cdef SCIP_EVENTHDLR* _getEventhdlr(self, object eventhdlr)
cdef SCIP_BENDERS* _getBenders(self, object benders)
cdef SCIP_HEUR* _getHeur(self, object heur)

@staticmethod
cdef create(SCIP* scip)
Loading
Loading