Repository navigation
improvement(async-jobs): warn when Trigger.dev run acceptance is slow - #9224
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Contributor
[Low impact] The PR appears safe to merge; no blocking issue was found. SummaryAdds shared timing logs around Trigger.dev submissions from
Reviews (2) · Last reviewed commit: "improvement(async-jobs): warn while Trig..." · Reviewed by Greptile |
…ending and emit at WARN in production
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
measureTriggerAcceptance, which logsSlow Trigger.dev run acceptance(withtaskId,durationMs, andoutcome) when Trigger.dev takes 10s or longer to accept a runtriggerScheduledPass(cron-dispatched passes) andTriggerDevJobQueue.enqueueType of Change
Testing
lib/core/async-jobs/backends/trigger-dev.test.ts(45 passing)biome checkon the changed filesoutcome: accepted, and a 10.2s failed submission warns withoutcome: failedand rethrows the original errorChecklist
test-auditauthoring gate)