Repository navigation
improvement(async-jobs): warn when Trigger.dev run acceptance is slow #9224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
waleedlatif1
merged 2 commits into
staging
from
improvement/trigger-slow-acceptance-log
Oct 19, 2026
+55
−7
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { createLogger } from '@sim/logger' | ||
|
|
||
| /** An operational signal, so it is emitted even where the production default level is ERROR. */ | ||
| const logger = createLogger('TriggerAcceptance', { logLevel: 'WARN' }) | ||
|
|
||
| /** | ||
| * Trigger.dev normally accepts a run in well under a second. A wait past this means its intake is | ||
| * stalling, and every enqueue in the process is waiting on it. | ||
| */ | ||
| const SLOW_TRIGGER_ACCEPTANCE_MS = 10_000 | ||
|
|
||
| /** | ||
| * Awaits a Trigger.dev run submission and warns when acceptance is slow: once while it is still | ||
| * pending, so a stall shows up as it happens, and again when it settles, with its duration and | ||
| * outcome. It never bounds the wait: a deadline would turn a late acceptance into one whose | ||
| * outcome is unknown. | ||
| */ | ||
| export async function measureTriggerAcceptance<T>( | ||
| taskId: string, | ||
| submit: () => Promise<T> | ||
| ): Promise<T> { | ||
| const startedAt = performance.now() | ||
| const pendingWarning = setTimeout(() => { | ||
| logger.warn('Trigger.dev run acceptance still pending', { | ||
| taskId, | ||
| waitedMs: SLOW_TRIGGER_ACCEPTANCE_MS, | ||
| }) | ||
| }, SLOW_TRIGGER_ACCEPTANCE_MS) | ||
| let outcome: 'accepted' | 'failed' = 'failed' | ||
| try { | ||
| const result = await submit() | ||
| outcome = 'accepted' | ||
| return result | ||
| } finally { | ||
| clearTimeout(pendingWarning) | ||
| const durationMs = Math.round(performance.now() - startedAt) | ||
| if (durationMs >= SLOW_TRIGGER_ACCEPTANCE_MS) { | ||
| logger.warn('Slow Trigger.dev run acceptance', { taskId, durationMs, outcome }) | ||
|
waleedlatif1 marked this conversation as resolved.
|
||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.