Repository navigation
e-stepper: step controls after a run, and a slider that counts from 0 - #157
Conversation
Before a run the slider and the step buttons had nothing to act on: a lone disabled handle and label, and disabled buttons. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Blueprint labelled every s-th value from the first, so with 174 steps the right end read 163. The slider now runs from 0 (the start) to the number of steps, and always labels both ends. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6084ffc3d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {/* The slider counts the steps taken: 0 is the start, the last is the total number. */} | ||
| <Slider | ||
| min={0} | ||
| max={lastStep - 1} |
There was a problem hiding this comment.
Avoid rendering a zero-width Slider range
When a run produces exactly one state, hasRun is true but this sets both min and max to 0. Blueprint's Slider expects max to be greater than min and calculates positions by dividing over that range, so this case emits validation errors and renders handle/label positions as NaN%. One-state runs are permitted by the runner protocol and are already used throughout this test suite; hide the slider for this case or give it a valid disabled range.
Useful? React with 👍 / 👎.
Blueprint's Slider needs max > min; with one state it was 0..0. The slider is now 0..1 and disabled then. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Tests: no controls before a run, and both after; the slider's range, value and labels, and stepping with the keys; the label values.
🤖 Generated with Claude Code