Skip to content

e-stepper: step controls after a run, and a slider that counts from 0 - #157

Merged
martin-henz merged 3 commits into
mainfrom
e-stepper-controls-after-run
Oct 9, 2026
Merged

martin-henz merged 3 commits into
mainfrom
e-stepper-controls-after-run

Conversation

@martin-henz

@martin-henz martin-henz commented Oct 9, 2026 •

Copy link
Copy Markdown
Member
  • Step controls only after a run. Before a run, the tab showed a lone disabled slider handle with its "1" label, and a row of disabled buttons. The slider and the button row now appear once there are steps.
  • The slider counts the steps taken. It ran from 1 to the number of states and labelled every ceil(n/10)-th value from 1, so with 174 states the right end read 163 (not 174). It now runs from 0 (the start of the evaluation) to the total number of steps (173 for 174 states), and always labels both ends, with round values in between (a value too close to the last gives way to it).

Tests: no controls before a run, and both after; the slider's range, value and labels, and stepping with the keys; the label values.

🤖 Generated with Claude Code

Before a run the slider and the step buttons had nothing to act on: a lone
disabled handle and label, and disabled buttons.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8d557bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Blueprint labelled every s-th value from the first, so with 174 steps the right
end read 163. The slider now runs from 0 (the start) to the number of steps,
and always labels both ends.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@martin-henz martin-henz changed the title e-stepper: the step controls appear once there is a run e-stepper: step controls after a run, and a slider that counts from 0 Oct 9, 2026
@martin-henz

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T13:32:59.454930Z 6084ffc Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6084ffc3d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/web/e-stepper/src/EStepperView.tsx Outdated
{/* The slider counts the steps taken: 0 is the start, the last is the total number. */}
<Slider
min={0}
max={lastStep - 1}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid rendering a zero-width Slider range

When a run produces exactly one state, hasRun is true but this sets both min and max to 0. Blueprint's Slider expects max to be greater than min and calculates positions by dividing over that range, so this case emits validation errors and renders handle/label positions as NaN%. One-state runs are permitted by the runner protocol and are already used throughout this test suite; hide the slider for this case or give it a valid disabled range.

Useful? React with 👍 / 👎.

Blueprint's Slider needs max > min; with one state it was 0..0. The slider is
now 0..1 and disabled then.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@martin-henz
martin-henz merged commit 78913be into main Oct 9, 2026
2 checks passed
@martin-henz
martin-henz deleted the e-stepper-controls-after-run branch October 9, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant