Skip to content

Add empty hidden header to properly render headerless tables - #211

Open
mielvds wants to merge 3 commits into
prepare-mkdocs-cifrom
migrate-empty-tables
Open

mielvds wants to merge 3 commits into
prepare-mkdocs-cifrom
migrate-empty-tables

Conversation

@mielvds

@mielvds mielvds commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

mnkdocs does not support headerless tables, so this PR adds an empty header and hides it.

@mielvds
mielvds added this pull request to stack #209 October 9, 2026 13:35
@mielvds
mielvds marked this pull request as ready for review October 14, 2026 09:01
@mielvds
mielvds force-pushed the migrate-empty-tables branch from 11b2a77 to 8ab8207 Compare October 14, 2026 11:14
@mielvds
mielvds removed this pull request from stack #209 October 15, 2026 07:43
@mielvds
mielvds added this pull request to stack #216 October 15, 2026 07:43
@mielvds
mielvds removed this pull request from stack #216 October 16, 2026 07:53
@mielvds
mielvds added this pull request to stack #217 October 20, 2026 06:46
@mielvds
mielvds force-pushed the migrate-empty-tables branch from 8ab8207 to 1a7f15f Compare October 20, 2026 07:07
@mielvds
mielvds requested a review from jaameemoo October 20, 2026 07:08
Comment thread src/docs/metadata/viaa/licenties.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't leave comments by the lines of the files in the submodules.

2 tables in 5_structure_package.md are broken due to the hidden header in the wrong place:

mets/dmdSec/mdRef
mets[@csip:CONTENTINFORMATIONTYPE="OTHER"]/@csip:OTHERCONTENTINFORMATIONTYPE

And 1 due to a missing column in the delimiter row.
Overview of relevant PREMIS relationships

The latter issue is also present in 6_structure_representation.md and both versions of film.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these are repeated over the different versions.

Also in 5_structure_package.md:
mets/fileSec/fileGrp[@use='Schemas']
mets/fileSec/fileGrp[@use=[starts-with('Representations')]]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other broken table (inadvertently split a table) in **/6_*.md:

elements-and-internal-references

@jaameemoo

Copy link
Copy Markdown
Contributor

Just thinking out loud. These headerless tables look more like description lists to me.

Apparently there's a markdown extension that can be enabled:

  markdown_extensions:
    - def_list

Syntax would be:

XML element
:   `<type/>`

These show up on separate lines, but could be styled using CSS to show up in 2 columns.

Might be more in line with semantic web sensibilities?

@mielvds

mielvds commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

@jaameemoo you are absolutely right. Deflists are definitely a better fit. I will have a look at my script to migrate those.

@mielvds

mielvds commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

@jaameemoo I fixed the tables and made the switch. Could you do another check?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants