Skip to content

fix(rolldown): include asset and package data in static reports - #598

Open
SaKaNa-Y wants to merge 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/rolldown-static-report-data
Open

SaKaNa-Y wants to merge 1 commit into
vitejs:mainfrom
SaKaNa-Y:fix/rolldown-static-report-data

Conversation

@SaKaNa-Y

@SaKaNa-Y SaKaNa-Y commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Important

Please take a moment to read this. Thank you!

I should include a brief explanation of the problem in my own words in every PR. If that explanation is missing, please @mention me and do not merge this PR until I have added it. You may also leave this PR unaddressed (because this means I have not fulfilled my responsibilities as the author).

If my explanation is unclear or difficult to follow, please ask me to clarify or provide reproduction steps or supporting evidence.

I welcome suggestions and counterarguments, especially questions about anything I may have overlooked. (Your feedback helps me learn and improve. 🙏)

I hold myself to this standard for every PR, regardless of its size.

When inspecting an existing build session, users can export a static DevTools report with pnpm exec vite-devtools build. The exported report should let them inspect the same assets, packages, and chunks shown by the running DevTools server. The session overview loads, but Assets is blank, Packages shows No data, and the Chunks graph has no nodes. These views cannot load their data because the export omits six RPC query results.

Add export inputs for the asset list, package list, and chunks graph in every session, plus each asset, chunk, and package detail query. Package details use IDs from the same normalized manifest as the query handler. The existing query handlers stay unchanged. Reports contain more records, so export work and output size grow with the number of assets, chunks, and packages. Static builds remain experimental. Related CLI documentation corrections: #600.

Verification

Rechecked commit 95416d84:

  • Exported the same real build record with the published Rolldown package and with the compiled PR package. All six query entries were missing before and present after the change.
  • Opened the repaired static report through a static file server. Assets showed two files, asset and chunk details loaded, Packages showed lodash-es with 31 bundled files in its details, and the Chunks graph showed two nodes. No browser console errors were recorded while visiting these views.
  • All seven static-report regression tests passed, including JSON replay for two sessions and an export with no sessions. The full suite passed: 358 tests passed, 2 skipped.
  • pnpm lint, pnpm typecheck, and pnpm build passed.

@pkg-pr-new

pkg-pr-new Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@598

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@598

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@598

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@598

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@598

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@598

commit: 95416d8

@webfansplz webfansplz reopened this Oct 2, 2026
@SaKaNa-Y
SaKaNa-Y marked this pull request as ready for review October 2, 2026 14:02
@SaKaNa-Y

SaKaNa-Y commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator Author

I compared the same build session in the running DevTools and the exported static report. Assets, Packages, and the Chunks graph showed data in the running DevTools.

The static report displayed the session overview, but these three views had no data. The browser console reported that the corresponding queries were missing from the dump store, which holds the exported query results.

@SaKaNa-Y
SaKaNa-Y requested a review from webfansplz October 2, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants