[lokewate]

Summary

Each task records the manifest version its parent workflow carries, so a task's steps, submissions, drafts and renders all resolve their templates through the version the flow started on.

Stack

Manifest versioning, in five PRs to review and merge in order. Each one builds and passes its tests on its own.

1. feat(artifact)!: load versioned manifests as a set #305 artifact: load versioned manifests as a set
2. feat(artifact)!: resolve explicitly versioned rows across manifests #346 artifact: resolve explicitly versioned rows across manifests
3. feat(artifact): load newer manifests on demand #319 artifact: load newer manifests on demand
4. feat(workflow)!: carry the manifest version through every workflow #322 workflow: carry the manifest version through every workflow
5. feat(taskflow)!: resolve a task's templates through its manifest version #306 taskflow: resolve a task's templates through its manifest version ← this PR

#320 (validate every artifact a manifest lists) and #321 (manifestcheck) are parked: pinning doesn't need them, and a release job can bring validation back later.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)
• Performance improvement
• Other (please describe):

Changes Made

• NewTaskManager takes an *artifact.Set.
• StartTask resolves the task template, its workflow and render config through the payload's version. It stores the version on the task record and seeds it into the task's own workflow.
• StartTaskStep, CompleteTaskStep and SaveDraft resolve the step template through the record's version, not the payload's. GetTaskRenderInfo and ZoneViewAssembler.Assemble (a host's task view) do the same for rendering.
• artifact.WithManifestVersion / ManifestVersionFrom. Each of those puts the version on the context, so plugins, extensions and the renderer's template provider can resolve through it too.
• A task without a version fails before anything is written. Falling back to the current version would change templates under a running task. The error is a non-retryable ApplicationError, returned unwrapped because Temporal reads retryability off the top-level error only. A version this replica has not loaded stays retryable, since Set.Registry loads newer manifests on demand.
• Store. TaskRecord.ManifestVersion is stored in column manifest_version.
• Breaking:
  • NewTaskManager takes an *artifact.Set;
  • hosts add manifest_version INTEGER NOT NULL DEFAULT 0 to the task records table;
  • workflows already running fail their next task.
• Logs: the task and step start logs name the manifest version, so a step's log says which templates it ran.

Testing

• I have tested this change locally
• I have added tests that prove my fix is effective or that my feature works
• I have tested edge cases
• All existing tests pass

Run with go test -race ./taskflow/.... The tests cover a task that keeps its starting version after the current version moves (through start, step, submit and extensions), SaveDraft on a versioned task, missing-version refusal as an unwrapped non-retryable error with nothing written and the step never claimed, an unpublished version staying retryable, and the renderer receiving the task's version.

Checklist

• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have checked that there are no merge conflicts

Related Issues

The host side is OpenNSW/nsw-srilanka#660. It records the version on each flow row, passes it at start, and adds the migration. Tracked in OpenNSW/one-trade-artifacts#243.

Screenshots/Demo

N/A

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6fe5d0f5-3320-4a6c-8a7d-577d56f4e7bd

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}