[lokewate]

Summary

A host starts each top-level workflow with VarManifestVersion (_manifest_version) set to the artifact manifest version current at that moment. The engine carries it unchanged to every child workflow and reports it to the host wherever the host resolves templates. The engine never resolves artifacts itself, so this PR does not depend on the artifact changes before it.

Stack

Manifest versioning, in five PRs to review and merge in order. Each one builds and passes its tests on its own.

1. feat(artifact)!: load versioned manifests as a set #305 artifact: load versioned manifests as a set
2. feat(artifact)!: resolve explicitly versioned rows across manifests #346 artifact: resolve explicitly versioned rows across manifests
3. feat(artifact): load newer manifests on demand #319 artifact: load newer manifests on demand
4. feat(workflow)!: carry the manifest version through every workflow #322 workflow: carry the manifest version through every workflow ← this PR
5. feat(taskflow)!: resolve a task's templates through its manifest version #306 taskflow: resolve a task's templates through its manifest version

#320 (validate every artifact a manifest lists) and #321 (manifestcheck) are parked: pinning doesn't need them, and a release job can bring validation back later.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)
• Performance improvement
• Other (please describe):

Changes Made

• ActivationRef and TaskPayload carry ManifestVersion, so every task activation names it.
• FetchWorkflowDefinitionActivity takes the version as a second argument, and RegisterDefinitionHandler takes a DefinitionHandler(manifestVersion, templateID), so a dynamic split's branches come from the calling workflow's manifest.
• AdminParkPayload carries the version, so a park handler can show the parked node's template from the flow's own manifest.
• Children. Dynamic-split children get the variable explicitly. Batch and parallel children already copy the engine's underscore variables.
• Temporal's JSON. A whole number that came back as a float64 is read as the integer. Anything that is not a positive whole number counts as no version (0).
• Breaking: the RegisterDefinitionHandler and FetchWorkflowDefinitionActivity signatures. taskflow's test mock is updated to match.

Testing

• I have tested this change locally
• I have added tests that prove my fix is effective or that my feature works
• I have tested edge cases
• All existing tests pass

Run with go test -race ./workflow/. The tests cover the version reaching every task activation in batch and parallel children, and the dynamic split's fetch and branches. A mutation check confirmed that dropping it from the split's children fails the test. They also cover manifestVersion() value forms (int, float64, json.Number, negative, fractional and string) and the admin park payload.

Checklist

• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have checked that there are no merge conflicts

Related Issues

Part of OpenNSW/one-trade-artifacts#243. Host: OpenNSW/nsw-srilanka#660.

Screenshots/Demo

N/A

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: accbd30f-f7fd-41bd-b491-8681f5a5ffe1

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

The merge-base changed after approval.

The merge-base changed after approval.