Repository navigation
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KeyInCode · support with no listed requirements · August · mixed requirements · Nuki · subscription and accessories · Salto · KS, Homelok and Space
The Supported Devices design review separates whether a capability is supported from its additional setup. Each provider's selected capability list now has Capability, Supported and Requirements columns. Green checks identify supported capabilities, amber pills identify required accessories/subscriptions, and a dash replaces None listed when no additional requirement is recorded. Native table headers and accessible labels describe checks and dashes. All three columns remain aligned at narrow widths; requirement pills stack inside the right column on mobile. Full source explanations sit below the provider table.
Expanded rows retain compact hardware strips with complete model identifiers, lock type, battery details and clickable catalog color swatches. Hover/keyboard/tap opens matching photos, with modal navigation, Escape, outside dismissal and focus restoration. Manufacturer/provider logos and every known provider remain visible, with the guide's provider first. Collapsed capability summaries and category pills stay scoped to that guide.
The review retains three compact row styles, a real 390px iPhone comparison, multi-capability AND filtering, an inset chevron, shareable filter/presentation URLs and bidirectional desktop/phone search and filter synchronization without reloading during typing. The earlier requirement matrix remains an explicit alternative.
Salto is available in the preview brand selector with Salto KS as the guide context. Its current catalog response has 57 models; expanded rows retain all known providers, including Homelok and Space, with their own logos and source requirements.
Schema trace: the live nuki-web provider has has_requirements=true and requirements_md describing its SmartHosting subscription. Ecosystem's evaluator copies provider-level requirements into each non-no device/provider capability's report.requirements.provider. There is no dedicated subscription_required field; the review recognizes the known Nuki message for its Subscription label and preserves unfamiliar text as Other. This PR does not change Ecosystem data or schema.
Validation: formatting/lint and all PR CI checks pass for 541e674. The deployed branch preview passes targeted Chrome checks for Salto's 57-model result, manufacturer/provider branding and model images, full provider requirement text, selector changes and reload persistence, synchronized desktop/iPhone search without navigation while typing, brand reset, both themes and 1600/760/390/320px outer windows. No browser errors or page overflow; catalog responses are 200/304. Earlier review checks also covered the support/dash/pill cases for KeyInCode, August and Nuki and hardware/photo interactions.
This remains an isolated design review at /examples/supported-devices-prototypes.
Design review: https://linear.app/seam/issue/DEVDB-466
Implementation and schema trace: https://linear.app/seam/issue/DEVDB-469
Phone comparison: https://linear.app/seam/issue/DEVDB-470